Re: Raw parse tree is not dumped to log

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: johncnaylorls(at)gmail(dot)com
Cc: li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Raw parse tree is not dumped to log
Date: 2025-09-03 01:57:29
Message-ID: 20250903.105729.896425663189147106.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> The individual runs have quite a bit of variation.

It's a known behavior of pgbench.

> It's good to cross check results against known facts. If my napkin
> math is right, a ~1% speedup for ~60ktps/s amounts to saving ~160ns
> per query. It's not plausible that forcing the compiler's hand for
> this branch would save several hundred clock cycles.
>
> To be fair I tried to reproduce and found only noise-level differences:
> master: 61553
> case 1: 61423
> case 2: 61647

That's 0.3% difference, definitely noise-level. Ok, I withdraw my
claim and commit the patch without unlikely().

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-09-03 01:57:42 Re: Add support for specifying tables in pg_createsubscriber.
Previous Message Michael Paquier 2025-09-03 01:21:54 Re: Update outdated references to SLRU ControlLock