Re: Enhance Makefiles to rebuild objects on map file changes

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: John Naylor <johncnaylorls(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Enhance Makefiles to rebuild objects on map file changes
Date: 2025-08-19 15:43:39
Message-ID: 202508191543.ftlhbkwxp4zc@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Aug-19, Chao Li wrote:

> Hi John,
>
> Let me explain the Makefile patch in this separate thread, as this is generic to all maps.
>
> Let’s not use gb18030 as an example, instead, using utf8_and_win.
>
> When any of the win-related map file changes, it suppose to automatically rebuild utf8_and_win.o.
>
> WITHOUT this patch, after I touch a map file, it doesn’t rebuild the object file:

Hmm. Yeah, this really looks somewhat bogus as you say. I wonder
though if we shouldn't have the UCS_to_*.pl scripts generate a bunch of
"mapdeps.mk" files instead, or something like that, given that these
*.map files are themselves generated.

Also, I suspect you should do something about Meson, but I don't know
what that would look like.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Thou shalt study thy libraries and strive not to reinvent them without
cause, that thy code may be short and readable and thy days pleasant
and productive. (7th Commandment for C Programmers)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-08-19 15:44:23 Re: fix misspelling of "tranche" in dsa.h
Previous Message Fujii Masao 2025-08-19 15:37:27 Re: Standardize LSN-based filename