| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: don't include tableam.h in nbtree.h |
| Date: | 2025-08-14 15:52:07 |
| Message-ID: | 202508141552.kosq2bvhduu2@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Aug-05, Bertrand Drouvot wrote:
> I think that makes sense.
Thanks for looking!
> index 1127597bb60..8282055ebca 100644
> --- a/contrib/btree_gist/btree_bool.c
> +++ b/contrib/btree_gist/btree_bool.c
> @@ -6,6 +6,7 @@
> #include "btree_gist.h"
> #include "btree_utils_num.h"
> #include "utils/sortsupport.h"
> +#include "utils/rel.h"
>
> There is several places like this one where the new include is not ordered based
> on the ASCII values (while it looks like it should be according to 7e735035f2).
Oh yeah, that's been the intention for many years. This was just me
failing to sort properly ... thanks for the patch, I included it and
pushed.
Cheers,
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-08-14 15:52:49 | Re: [PATCH] bms_prev_member() can read beyond the end of the array of allocated words |
| Previous Message | David Rowley | 2025-08-14 15:49:06 | Re: [PATCH] bms_prev_member() can read beyond the end of the array of allocated words |