| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Implement waiting for wal lsn replay: reloaded |
| Date: | 2025-08-05 13:47:07 |
| Message-ID: | 202508051347.nkdgrhmjyb2l@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Apr-29, Alexander Korotkov wrote:
> > 11) WaitLSNProcInfo / WaitLSNState
> >
> > Does this need to be exposed in xlogwait.h? These structs seem private
> > to xlogwait.c, so maybe declare it there?
>
> Hmm, I don't remember why I moved them to xlogwait.h. OK, moved them
> back to xlogwait.c.
This change made the code no longer compile, because
WaitLSNState->minWaitedLSN is used in xlogrecovery.c which no longer has
access to the field definition. A rebased version with that change
reverted is attached.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Thou shalt study thy libraries and strive not to reinvent them without
cause, that thy code may be short and readable and thy days pleasant
and productive. (7th Commandment for C Programmers)
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Implement-WAIT-FOR-command.patch | text/x-diff | 60.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2025-08-05 14:33:38 | Re: Test to dump and restore objects left behind by regression |
| Previous Message | Nikita Malakhov | 2025-08-05 13:14:35 | Re: Dead code with short varlenas in toast_save_datum() |