| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | don't include tableam.h in nbtree.h |
| Date: | 2025-08-05 11:09:57 |
| Message-ID: | 202508051109.lzk3lcuzsaxo@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I noticed that nbtree.h includes tableam.h. This seems rather random
and unnecessary. This patch removes it and fixes fallout, which is
pretty minimal. We do need to add a forward declaration of struct
TM_IndexDeleteOp (whose full definition appears in tableam.h) so that
_bt_delitems_delete_check()'s declaration can use it.
Also remove xlogreader.h, which is AFAICS 100% useless here.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Avoid-including-tableam.h-and-xlogreader.h-into-nbtr.patch | text/x-diff | 12.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-08-05 11:18:32 | Re: Dropping publication breaks logical replication |
| Previous Message | Jean-Christophe Arnu | 2025-08-05 10:40:32 | Re: restore_command return code behaviour |