Re: pg_dump --with-* options

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump --with-* options
Date: 2025-07-30 20:04:14
Message-ID: 202507302004.bjwvd3jk6rh6@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Jul-30, Jeff Davis wrote:

> On Wed, 2025-07-30 at 10:23 +0200, Álvaro Herrera wrote:
> > Maybe we should invent a new
> > switch, something like
> >   --include=[schema,data,statistics]
> > with which users can give one or more comma-separated types to be
> > included in the dump. 
>
> Robert Treat brought up a similar idea before:
>
> https://www.postgresql.org/message-id/CABV9wwO5v8Nu8q%2BxWexMdL3Z%2B2xS%3DfFJMQetBSHy3tR64wNHOA%40mail.gmail.com

Oh, I hadn't seen it, but now that I do, it seems identical to mine. He
even used some of the same terms I did.

> > Then we state that --data-only is synonym for --include=data and
> > --schema-only is synonym for --include=schema, and we don't need any
> > other switches.  Then it is obvious what happens, how to combine
> > object types in the dumps and restores, and there's no need to reject
> > invalid combinations because there aren't any.
>
> I assume that should be read as something like "include only", because
> --include=data would also be excluding the schema and the stats.

Of course.

> And if that's the case, it does seem strange to do something like "--
> include=data --schema-only".

> Another question: could you have multiple --include options, like "--
> include=data --include=schema"? Because you currently can't do "--data-
> only --schema-only". So that would make it not quite an alias.

IMO we should only allow one --include.

> If we go in this direction, it might be easier to just say that --
> include conflicts with --schema-only and --data-only.

Yep.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Small aircraft do not crash frequently ... usually only once!"
(ponder, http://thedailywtf.com/)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2025-07-30 20:09:08 Re: track generic and custom plans in pg_stat_statements
Previous Message Peter Eisentraut 2025-07-30 19:58:00 Re: Support getrandom() for pg_strong_random() source