| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: trivial grammar refactor |
| Date: | 2025-07-24 09:54:10 |
| Message-ID: | 202507240954.uage7twscx4s@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
On 2025-Jul-23, Andres Freund wrote:
> On 2025-07-23 19:59:52 +0200, Álvaro Herrera wrote:
> > ... so using the same set of productions, I can rewrite the current
> > CLUSTER rule in this way and it won't be a problem for the REPACK
> > changes.
>
> But it comes at the price of henceforth duplicating all ClusterStmt, once for
> VERBOSE and once without. That's not exactly a free lunch...
Yeah, thanks for taking a look. That duplication is just me being dumb.
Here's a version without that. The only thing that needed to change was
changing "CLUSTER opt_verbose" to "CLUSTER VERBOSE" so that the
unadorned CLUSTER is handled by "CLUSTER opt_utility_option_list"
instead.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"How amazing is that? I call it a night and come back to find that a bug has
been identified and patched while I sleep." (Robert Davidson)
http://archives.postgresql.org/pgsql-sql/2006-03/msg00378.php
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Refactor-grammar-to-create-opt_utility_option_lis.patch | text/x-diff | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2025-07-24 10:34:30 | Re: Improve error reporting in 027_stream_regress test |
| Previous Message | shveta malik | 2025-07-24 09:46:08 | Re: Logical replication launcher did not automatically restart when got SIGKILL |