Re: Log prefix missing for subscriber log messages received from publisher

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Log prefix missing for subscriber log messages received from publisher
Date: 2025-07-22 11:47:09
Message-ID: 202507221147.sdg2rmhbqb5z@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Jul-22, Fujii Masao wrote:

> Is the issue caused by the use of _() in libpq-be-fe-helpers.h,
> instead of using gettext_noop() in dblink.c? At least in my test
> environment, the build error disappeared after applying
> the following change:
>
> - errmsg_internal("%s: %.*s", _(prefix), len, message));
> + errmsg_internal("%s: %.*s", prefix, len, message));

Oh yeah, I should have remembered this -- see commit 213c959a294d. Feel
free to do away with the whole translation thing ... doesn't seem worth
spending more time on it.

We should still remove all gettext_noop() markers in contrib :-)

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matheus Alcantara 2025-07-22 11:55:56 Re: Proposal: QUALIFY clause
Previous Message Ashutosh Bapat 2025-07-22 11:40:26 Re: SQL Property Graph Queries (SQL/PGQ)