| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log prefix missing for subscriber log messages received from publisher |
| Date: | 2025-07-18 20:09:33 |
| Message-ID: | 202507182009.rokwnhssvvy5@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Jul-18, vignesh C wrote:
> diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
> index 304f3c20f83..c1ce6f33436 100644
> --- a/contrib/postgres_fdw/connection.c
> +++ b/contrib/postgres_fdw/connection.c
> @@ -625,6 +625,9 @@ connect_pg_server(ForeignServer *server, UserMapping *user)
> server->servername),
> errdetail_internal("%s", pchomp(PQerrorMessage(conn)))));
>
> + PQsetNoticeReceiver(conn, libpqsrv_notice_receiver,
> + "received message via remote connection");
> +
These need to be:
PQsetNoticeReceiver(conn, libpqsrv_notice_receiver,
gettext_noop("received message via remote connection"));
so that the strings are picked up by gettext.
Also, I don't see why there are three patches here instead of just one.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-07-18 20:48:00 | Re: Adding basic NUMA awareness |
| Previous Message | Pavel Stehule | 2025-07-18 19:57:12 | Re: Documenting inlining SQL functions |