Re: Inconsistent LSN format in pg_waldump output

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: Japin Li <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Inconsistent LSN format in pg_waldump output
Date: 2025-07-07 15:04:26
Message-ID: 202507071504.xm2r26u7lmzr@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Jul-07, Ashutosh Bapat wrote:

> I am wondering whether we should question the restriction on using
> format macros because of translations.

Sure Mr. Quixote, the windmills are over there.

> In fact, these format macros can actually aid translations e.g. if the
> translation sees LSN_FORMAT instead of %X/%X, it can use that
> knowledge to better translate the message since it knows that it's an
> LSN instead of two sets of hex numbers separated by /. If we could
> devise a prefix which will tell them that what comes next is a FORMAT
> for a special datatype, would the translation system be able to make
> use of this information.

You'd have to talk with the gettext developers and then wait a decade or
so for all the live distributions get a patched gettext release. For
GNU gettext, this is explained at the bottom of this page:
https://www.gnu.org/software/gettext/manual/html_node/No-string-concatenation.html
I frankly wouldn't waste my time.

Meanwhile, crake is failing the cross-version upgrade test because of
this change, and I'm not sure what solution I'm going to offer. Maybe
use the AdjustUpgrade.pm infrastructure to set all the pg_lsn column
values to NULL if the old version is earlier than 19 and the new version
is 19 or later :-)

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Syntax error: function hell() needs an argument.
Please choose what hell you want to involve.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2025-07-07 15:07:12 Re: Adding wait events statistics
Previous Message Álvaro Herrera 2025-07-07 15:01:52 Re: Elimination of the repetitive code at the SLRU bootstrap functions.