| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | koshino(at)sraoss(dot)co(dot)jp |
| Cc: | pgpool-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Patch for fixing doc about some parameters. |
| Date: | 2025-07-02 11:27:13 |
| Message-ID: | 20250702.202713.220401050993902307.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgpool-hackers |
> Fixed mistakes in the documentation for parameters.
>
> "v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch"
> is a patch for ticket #10954
> "Test all the configuration parameters if reload is required."
There's one trainling whitespace.
$ git apply ~/v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch
/home/t-ishii/v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch:39: trailing whitespace.
このパラメータはサーバ起動時にのみ設定可能です。
warning: 1 line adds whitespace errors.
> Subject: [PATCH v2] Fixed documentation for parameters that are not reflected
by reload.
This comes from the commit title "Fixed documentation for parameters
that are not reflected by reload." We usually add "Doc:" prefix to the
commit header if the changes are only for documentations. Also "Fixed"
seems unnatural as a commit header. Instead use "fix". So something
like "Doc: fix documentation for parameters that are not reflected by
reload." is better,
> "v1-0001-Fix-documentation-for-enum-parameters-reported-as"
> is for ticket #8397
Please add "Doc:" prefix to the commit title as well.
#8397 is an internal number and you'd better to remove it.
Other than that, the patch looks good to me.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Koshino Taiki | 2025-07-04 06:15:22 | Re: Patch for fixing doc about some parameters. |
| Previous Message | Bo Peng | 2025-07-02 08:38:16 | Re: Patch for fixing doc about some parameters. |