Re: Default value of health_check_database

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: pengbo(at)sraoss(dot)co(dot)jp
Cc: pgpool-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Default value of health_check_database
Date: 2025-06-30 07:04:29
Message-ID: 20250630.160429.2099283272319290326.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgpool-hackers

> The default value of "health_check_database" in the source code is "postgres".
>
> https://github.com/pgpool/pgpool2/blob/master/src/config/pool_config_variables.c#L1895
>
> However, in the sample configuration file and documentation, the default is shown as an empty string (''):
>
> (pgpool.conf)
> #health_check_database = ''
>
> (documetation)
> https://www.pgpool.net/docs/latest/en/html/runtime-config-health-check.html#GUC-HEALTH-CHECK-DATABASE
>
> | Specifies the PostgreSQL database name to perform health check. The default is ''(empty),
> | which tries "postgres" database first, then "template1" database until it succeeds

Since 3.7, we do not fallback to template1 if postgres database (or
other database if specified by health_check_database) fails.

> Should we update the sample file and documentation to reflect the actual default value "postgres"?

+1.

Plus, I think we should fix the documentation to remove the fallback
part, something like:

Specifies the PostgreSQL database name to perform health check. The
default is "postgres" database. If it is ''(empty), use "postgres"
database.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgpool-hackers by date

  From Date Subject
Next Message Koshino Taiki 2025-07-02 00:37:44 Patch for fixing doc about some parameters.
Previous Message Bo Peng 2025-06-30 06:33:06 Default value of health_check_database