Re: Documentation fix on pgbench \aset command

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Documentation fix on pgbench \aset command
Date: 2025-06-26 16:31:48
Message-ID: 20250627013148.95b4fddd51e5164484ad358e@sraoss.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 27 Jun 2025 01:05:47 +0900
Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:

>
>
> On 2025/06/26 18:01, Yugo Nagata wrote:
> > Hi,
> >
> > The current documentation of pgbench’s \aset command states:
> >
> > “If a query returns no row, no assignment is made and the variable
> > can be tested for existence to detect this.”
> >
> > However, this is inaccurate, since variable existence check (like \if :{?var})
> > is not yet supported, although such a feature was proposed in [1] and discussed
> > again in [2], where \aset itself was introduced.
>
> Right.
>
>
> > Therefore, I’ve attached a patch to remove this part from the documentation.
>
> Or would it be worth documenting an alternative way to detect when no rows are
> returned? For example:
>
> If a query returns no rows, no variables are assigned. You can detect
> this by setting an initial value to the variable before running the query
> and checking whether it changes.

That's what I thought as well, but I didn’t do it because we can’t distinguish it
from the case where the query returns the same value as the initial one.

To detect it correctly, we would need to reconsider the variable existence check,
or introduce a new meta-command or a special variable that indicates the number of
rows returned by the previous query, and so on.

Regards,
Yugo Nagata

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-06-26 16:42:46 Re: queryId constant squashing does not support prepared statements
Previous Message Álvaro Herrera 2025-06-26 16:31:23 Re: pg_dump misses comments on NOT NULL constraints