Re: pg_dump misses comments on NOT NULL constraints

On 2025-Jun-25, Álvaro Herrera wrote:

> Yeah, I think in this case we need to extract the constraint name so
> that we have it available to print the COMMENT command, rather than
> making any assumptions about it. In fact I suspect this would fail if
> the table or column names are very long. For the other pg_dump uses of
> this logic it doesn't matter AFAIR, but here I think we must be
> stricter.

As attached.

I'm bothered by this not having any tests -- I'll see about adding some
after lunch. But at least, this seems to be dumped correctly:

CREATE TABLE supercallifragilisticexpialidocious ("dociousaliexpilistic fragilcalirupus" int not null);
COMMENT ON CONSTRAINT "supercallifragilisticexpial_dociousaliexpilistic fragi_not_null" ON public.supercallifragilisticexpialidocious IS 'long names, huh?';

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/