Re: pg_dump misses comments on NOT NULL constraints

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_dump misses comments on NOT NULL constraints
Date: 2025-06-18 08:53:21
Message-ID: 202506180853.mqm3u7qov52b@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Jun-18, Fujii Masao wrote:

> On 2025/06/18 9:13, Fujii Masao wrote:

> > In v18, we can now add comments on NOT NULL constraints. However, I noticed
> > that pg_dump doesn't include those comments in its output. For example:

This is definitely a bug, thanks for reporting.

> I ran into another issue related to comments on NOT NULL constraints.
> When using CREATE TABLE ... (LIKE ... INCLUDING ALL), the NOT NULL constraints
> are copied, but their comments are not.

... and I agree that it'd be good to fix this one as well.

Jian He just mentioned to me that he's looking into these problems.
Many thanks to him. I'm pretty much unable to get anything done this
week, but I'll be back online next week.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming" (A. Stepanov)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-06-18 08:58:22 Re: minimum Meson version
Previous Message Arseniy Mukhin 2025-06-18 08:33:38 Re: amcheck support for BRIN indexes