Re: queryId constant squashing does not support prepared statements

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: queryId constant squashing does not support prepared statements
Date: 2025-05-27 15:58:57
Message-ID: 202505271558.uitgzyoan2ud@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-May-24, Sami Imseih wrote:

> therefore, a user supplied query like this:
> ```
> select where $5 in ($1, $2, $3) and $6 = $4 and 1 = 2
> ```
>
> will be normalized to:
> ```
> select where $1 in ($2 /*...*/) and $3 = $4 and $5 = $6
> ```

Hmm, interesting.

I think this renumbering should not be a problem in practice; users with
unordered parameters have little room to complain if the param numbers
change on query normalization. At least that's how it seems to me.

If renumbering everything in physical order makes the code simpler, then
I don't disagree.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Puedes vivir sólo una vez, pero si lo haces bien, una vez es suficiente"

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2025-05-27 17:55:39 Re: Automatically sizing the IO worker pool
Previous Message Fujii Masao 2025-05-27 15:36:01 Re: Make wal_receiver_timeout configurable per subscription