| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: remove open-coded popcount in acl.c |
| Date: | 2025-03-12 18:34:16 |
| Message-ID: | 202503121834.nrw4lp5mwd7v@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Mar-12, Nathan Bossart wrote:
> On Wed, Mar 12, 2025 at 05:23:25PM +0100, Álvaro Herrera wrote:
> > Strange: this code is not covered by any tests.
> >
> > https://coverage.postgresql.org/src/backend/utils/adt/acl.c.gcov.html#5533
> > https://coverage.postgresql.org/src/backend/utils/adt/acl.c.gcov.html#5438
>
> Huh. Well, it's easy enough to add some basic tests for the grantor
> selection machinery. Here's a first try.
Thanks :-) I confirm that this covers the code in select_best_grantor
that you're modifying.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Ed is the standard text editor."
http://groups.google.com/group/alt.religion.emacs/msg/8d94ddab6a9b0ad3
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-03-12 18:35:39 | Re: remove open-coded popcount in acl.c |
| Previous Message | Nathan Bossart | 2025-03-12 18:32:07 | Re: [PATCH] SVE popcount support |