| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Maxim Orlov <orlovmg(at)gmail(dot)com>, Svetlana Derevyanko <s(dot)derevyanko(at)postgrespro(dot)ru> |
| Subject: | Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs |
| Date: | 2025-03-12 09:41:43 |
| Message-ID: | 202503120941.6zkwny2okkan@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2025-Mar-11, Alexander Korotkov wrote:
> Thank you for your feedback! I also think that pipelining would be a
> better options, but it's too invasive for backpatching. I've written
> comments for gen_reindex_command() and run_reindex_command(). I'm
> going to push this patch to master and 17 if no objections.
Looks good.
Actually, I don't understand why is run_reindex_command() calling
PQfinish(). Hmm, also, why is the 'async' parameter always given as
true? Is that PQfinish() actually dead code?
[... Looks at git history ...]
Ah! this is actually a problem older than your patch -- it appears that
the last (only?) caller with async=false was removed by commit
2cbc3c17a5c1. I think it's worth removing that while you're at it. We
no longer need executeMaintenanceCommand() in reindexdb.c anymore
either, I think.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-03-12 11:41:38 | pgsql: Remove initialization from PendingBackendStats |
| Previous Message | David Rowley | 2025-03-12 08:37:35 | Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2025-03-12 09:45:48 | Re: Conflict detection for multiple_unique_conflicts in logical replication |
| Previous Message | Amit Kapila | 2025-03-12 09:30:13 | Re: Selectively invalidate caches in pgoutput module |