| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Better error message when --single is not the first arg to postgres executable |
| Date: | 2024-12-03 17:22:43 |
| Message-ID: | 202412031722.v3jlfbllozqc@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Dec-03, Nathan Bossart wrote:
> +Subprogram
> +parse_subprogram(const char *name)
> +{
Please add a comment atop this function. Also, I don't think it should
go at the end of the file; maybe right after main() is a more
appropriate location?
> +/* special must-be-first options for dispatching to various subprograms */
> +typedef enum Subprogram
> +{
I'm not sure this comment properly explains what this enum is used for.
Maybe add a reference to parse_subprogram to the comment?
Thanks
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Al principio era UNIX, y UNIX habló y dijo: "Hello world\n".
No dijo "Hello New Jersey\n", ni "Hello USA\n".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-12-03 17:47:04 | Re: Remove useless casts to (void *) |
| Previous Message | Nathan Bossart | 2024-12-03 17:05:34 | Re: Better error message when --single is not the first arg to postgres executable |