| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tender Wang <tndrwang(at)gmail(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Subject: | Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails |
| Date: | 2024-10-25 08:30:33 |
| Message-ID: | 202410250830.puisbzuy4yyj@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Oct-25, Tender Wang wrote:
> Thanks for reporting. I can reproduce this memory invalid access on HEAD.
> After debuging codes, I found the root cause.
> In DetachPartitionFinalize(), below code:
> att = TupleDescAttr(RelationGetDescr(partRel),
> attmap->attnums[conkey[i] - 1] - 1);
>
> We should use confkey[i] -1 not conkey[i] - 1;
Wow, how embarrasing, now that's one _really_ stupid bug and it's
totally my own. Thanks for the analysis! I'll get this patched soon.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-10-25 08:30:58 | Re: Docs Build in CI failing with "failed to load external entity" |
| Previous Message | Andreas Karlsson | 2024-10-25 08:16:55 | Re: simplify regular expression locale global variables |