| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Subject: | Re: BitmapHeapScan streaming read user and prelim refactoring |
| Date: | 2024-06-19 16:51:31 |
| Message-ID: | 202406191651.57ox5ym5dckn@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Jun-14, Melanie Plageman wrote:
> Subject: [PATCH v21 12/20] Update variable names in bitmap scan descriptors
>
> The previous commit which added BitmapTableScanDesc and
> BitmapHeapScanDesc used the existing member names from TableScanDescData
> and HeapScanDescData for diff clarity. This commit renames the members
> -- in many cases by removing the rs_ prefix which is not relevant or
> needed here.
*Cough* Why? It makes grepping for struct members useless. I'd rather
keep these prefixes, as they allow easier code exploration. (Sometimes
when I need to search for uses of some field with a name that's too
common, I add a prefix to the name and let the compiler guide me to
them. But that's a waste of time ...)
Thanks,
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Cuando mañana llegue pelearemos segun lo que mañana exija" (Mowgli)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yura Sokolov | 2024-06-19 17:00:28 | Re: Maybe don't process multi xmax in FreezeMultiXactId() if it is already marked as invalid? |
| Previous Message | Tomas Vondra | 2024-06-19 16:38:35 | Re: BitmapHeapScan streaming read user and prelim refactoring |