Re: CompilerWarnings task does not catch C++ warnings

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CompilerWarnings task does not catch C++ warnings
Date: 2024-06-18 14:31:16
Message-ID: 20240618143116.sgjwk3aynyv5wlw3@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2024-06-18 09:27:02 +0200, Peter Eisentraut wrote:
> The CompilerWarnings task on Cirrus CI does not catch warnings in C++ code.
> It tries to make warnings fatal by passing COPT='-Werror', but that does not
> apply to C++ compilations.
>
> I suggest that we just add COPT to CXXFLAGS as well. I think passing
> -Werror is just about the only reasonable use of COPT nowadays, so making
> that more robust seems useful. I don't think there is a need for a separate
> make variable for C++ here.

+1

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-06-18 14:32:43 Re: Truncation of mapped catalogs (whether local or shared) leads to server crash
Previous Message Yura Sokolov 2024-06-18 14:31:15 Re: Suggest two small improvements for PITR.