Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

On Wed, May 08, 2024 at 10:09:46AM +0200, Peter Eisentraut wrote:
> On 03.05.24 19:13, Nathan Bossart wrote:
>> This is likely small potatoes compared to some of the other
>> pg_upgrade-related improvements I've proposed [0] [1] or plan to propose,
>> but this is easy enough, and I already wrote the patch, so here it is.
>> AFAICT there's no reason to bother syncing these dump files to disk. If
>> someone pulls the plug during pg_upgrade, it's not like you can resume
>> pg_upgrade from where it left off. Also, I think we skipped syncing before
>> v10, anyway, as the --no-sync flag was only added in commit 96a7128, which
>> added the code to sync dump files, too.
>
> Looks good to me.

Thanks for looking. I noticed that the version check is unnecessary since
we always use the new binary's pg_dump[all], so I removed that in v2.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com