| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fixup some StringInfo usages |
| Date: | 2024-04-09 01:34:12 |
| Message-ID: | 20240409013412.GA1431559@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 09, 2024 at 12:53:21PM +1200, David Rowley wrote:
> Similar to f736e188c, I've attached a patch that fixes up a few
> misusages of the StringInfo functions. These just swap one function
> call for another function that is more suited to the use case.
>
> I've also attached the patch that I used to find these. That's not
> intended for commit.
>
> I feel like it's a good idea to fix these soon while they're new
> rather than wait N years and make backpatching bug fixes possibly
> harder.
>
> I've attached a file with git blame commands to identify where all of
> these were introduced. All are new to PG17.
>
> Any objections?
Looks reasonable to me.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-04-09 02:07:45 | Re: pgsql: Fix the intermittent buildfarm failures in 040_standby_failover_ |
| Previous Message | David Rowley | 2024-04-09 00:53:21 | Fixup some StringInfo usages |