Re: broken JIT support on Fedora 40

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: broken JIT support on Fedora 40
Date: 2024-04-05 13:21:06
Message-ID: 20240405132106.ysdjkbtre4hicmp4@erthalion.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On Sat, Apr 06, 2024 at 02:00:38AM +1300, Thomas Munro wrote:
> On Sun, Mar 31, 2024 at 12:49 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> >
> Oh, with those clues, I think I might see... It is a bit strange that
> we copy attributes from AttributeTemplate(), a function that returns
> Datum, to our void deform function. It works (I mean doesn't crash)
> if you just comment this line out:
> llvm_copy_attributes(AttributeTemplate, v_deform_fn);
> ... but I guess that disables inlining of the deform function? So
> perhaps we just need to teach that thing not to try to copy the return
> value's attributes, which also seems to work here:

Yep, I think this is it. I've spent some hours trying to understand why
suddenly deform function has noundef ret attribute, when it shouldn't --
this explains it and the proposed change fixes the crash. One thing that
is still not clear to me though is why this copied attribute doesn't
show up in the bitcode dumped right before running inline pass (I've
added this to troubleshoot the issue).

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-04-05 13:23:43 Re: Security lessons from liblzma
Previous Message Dmitry Koval 2024-04-05 13:00:44 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands