Re: DOCS: add helpful partitioning links

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: Robert Treat <rob(at)xzilla(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DOCS: add helpful partitioning links
Date: 2024-03-28 17:52:29
Message-ID: 202403281752.blk6524qy4n3@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-Mar-28, Ashutosh Bapat wrote:

> LGTM.
>
> The commitfest entry is marked as RFC already.
>
> Thanks for taking care of the comments.

Thanks for reviewing. I noticed a typo "seperate", fixed here. Also, I
noticed that Robert added an empty line which looks in the source like
he's breaking the paragraph -- but because he didn't add a closing </para>
and an opening <para> to the next one, there's no actual new paragraph
in the HTML output.

My first instinct was to add those. However, upon reading the text, I
noticed that the previous paragraph ends without offering an example,
and then we attach the example to the paragraph that takes about CREATE
TABLE LIKE showing both techniques, which seemed a bit odd. So instead
I joined both paragraphs back together. I'm unsure which one looks
better. Which one do you vote for?

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"No hay ausente sin culpa ni presente sin disculpa" (Prov. francés)

Attachment Content-Type Size
with-extra-para.png image/png 101.7 KB
no-extra-para.png image/png 101.5 KB
0001-doc-Improve-Partition-Maintenance-section.patch text/x-diff 7.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2024-03-28 17:53:30 Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Previous Message Bruce Momjian 2024-03-28 17:45:54 Re: Possibility to disable `ALTER SYSTEM`