Re: pgsql: Track last_inactive_time in pg_replication_slots.

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Track last_inactive_time in pg_replication_slots.
Date: 2024-03-26 07:39:52
Message-ID: 202403260739.udlp7lxixktx@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2024-Mar-26, Amit Kapila wrote:

> We have a consensus on inactive_since, so I'll make that change.

Sounds reasonable. So this is a timestamptz if the slot is inactive,
NULL if active, right? What value is it going to have for sync slots?

> I would also like to solicit your opinion on the other slot-level
> parameter we are planning to introduce. This new slot-level parameter
> will be named as inactive_timeout.

Maybe inactivity_timeout?

> This will indicate that once the slot is inactive for the
> inactive_timeout period, we will invalidate the slot. We are also
> discussing to have this parameter (inactive_timeout) as GUC [1]. We
> can have this new parameter both at the slot level and as well as a
> GUC, or just one of those.

replication_slot_inactivity_timeout?

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
Tom: There seems to be something broken here.
Teodor: I'm in sackcloth and ashes... Fixed.
http://postgr.es/m/482D1632.8010507@sigaev.ru

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2024-03-26 08:13:32 Re: pgsql: make dist uses git archive
Previous Message Peter Eisentraut 2024-03-26 07:30:56 Re: pgsql: pg_createsubscriber: creates a new logical replica from a standb

Browse pgsql-hackers by date

  From Date Subject
Next Message walther 2024-03-26 07:43:54 Re: Regression tests fail with musl libc because libpq.so can't be loaded
Previous Message Peter Eisentraut 2024-03-26 07:36:58 Re: make dist using git archive