Re: RangeTblEntry.inh vs. RTE_SUBQUERY

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RangeTblEntry.inh vs. RTE_SUBQUERY
Date: 2024-02-29 19:07:20
Message-ID: 202402291907.e6ax6kfnktt4@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-Feb-29, Tom Lane wrote:

> I agree that perminfoindex seems to have suffered from add-at-the-end
> syndrome, and if we do touch the field order you made an improvement
> there. (BTW, who thought they needn't bother with a comment for
> perminfoindex?)

There is a comment for it, or at least a61b1f74823c added one, though
not immediately adjacent. I do see that it's now further away than it
was. Perhaps we could add /* index of RTEPermissionInfo entry, or 0 */
to the line.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"The ability of users to misuse tools is, of course, legendary" (David Steele)
https://postgr.es/m/11b38a96-6ded-4668-b772-40f992132797@pgmasters.net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Phil Florent 2024-02-29 19:12:02 RE: Remove AIX Support (was: Re: Relation bulk write facility)
Previous Message Jeff Davis 2024-02-29 19:06:22 Re: Comments on Custom RMGRs