| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Smith <smithpb2250(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Relation bulk write facility |
| Date: | 2024-02-25 19:43:22 |
| Message-ID: | 20240225194322.a5@rfd.leadboat.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 25, 2024 at 04:34:47PM +0200, Heikki Linnakangas wrote:
> I agree with Andres though, that unless someone raises their hand and
> volunteers to properly maintain the AIX support, we should drop it.
There's no way forward in which AIX support stops doing net harm. Even if AIX
enthusiasts intercepted would-be buildfarm failures and fixed them before
buildfarm.postgresql.org could see them, the damage from the broader community
seeing the AIX-specific code would outweigh the benefits of AIX support. I've
now disabled the animals for v17+, though each may do one more run before
picking up the disable.
My upthread observation about xcoff section alignment was a red herring. gcc
populates symbol-level alignment, and section-level alignment is unnecessary
if symbol-level alignment is correct. The simplest workaround for $SUBJECT
AIX failure would be to remove the "const", based on the results of the
attached test program. The pg_prewarm.c var is like al4096_static in the
outputs below, hence the lack of trouble there. The bulk_write.c var is like
al4096_static_const_initialized.
==== gcc 8.3.0
al4096 4096 @ 0x11000c000 (mod 0)
al4096_initialized 4096 @ 0x110000fd0 (mod 4048 - BUG)
al4096_const 4096 @ 0x11000f000 (mod 0)
al4096_const_initialized 4096 @ 0x10000cd00 (mod 3328 - BUG)
al4096_static 4096 @ 0x110005000 (mod 0)
al4096_static_initialized 4096 @ 0x110008000 (mod 0)
al4096_static_const 4096 @ 0x100000c10 (mod 3088 - BUG)
al4096_static_const_initialized 4096 @ 0x100003c10 (mod 3088 - BUG)
==== xlc 12.01.0000.0000
al4096 4096 @ 0x110008000 (mod 0)
al4096_initialized 4096 @ 0x110004000 (mod 0)
al4096_const 4096 @ 0x11000b000 (mod 0)
al4096_const_initialized 4096 @ 0x100007000 (mod 0)
al4096_static 4096 @ 0x11000e000 (mod 0)
al4096_static_initialized 4096 @ 0x110001000 (mod 0)
al4096_static_const 4096 @ 0x110011000 (mod 0)
al4096_static_const_initialized 4096 @ 0x1000007d0 (mod 2000 - BUG)
==== ibm-clang 17.1.1.2
al4096 4096 @ 0x110001000 (mod 0)
al4096_initialized 4096 @ 0x110004000 (mod 0)
al4096_const 4096 @ 0x100001000 (mod 0)
al4096_const_initialized 4096 @ 0x100005000 (mod 0)
al4096_static 4096 @ 0x110008000 (mod 0)
al4096_static_initialized 4096 @ 0x11000b000 (mod 0)
al4096_static_const 4096 @ 0x100009000 (mod 0)
al4096_static_const_initialized 4096 @ 0x10000d000 (mod 0)
| Attachment | Content-Type | Size |
|---|---|---|
| align.c | text/plain | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-02-25 19:51:31 | Re: Relation bulk write facility |
| Previous Message | Tomas Vondra | 2024-02-25 19:13:33 | Re: Logging parallel worker draught |