| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "ranier(dot)vf(at)gmail(dot)com" <ranier(dot)vf(at)gmail(dot)com>, chap(at)anastigmatix(dot)net |
| Subject: | Re: Should we remove -Wdeclaration-after-statement? |
| Date: | 2024-01-29 15:37:57 |
| Message-ID: | 20240129153757.GA3291287@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 29, 2024 at 10:23:38AM -0500, Tom Lane wrote:
> Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> writes:
>> I feel like this is the type of change where there's not much
>> discussion to be had. And the only way to resolve it is to use some
>> voting to gauge community opinion.
>
>> So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
>> +1 to indicate support against/for the change.
>
>> I'll start: +1
>
> [ shrug... ] -1 here.
-1 here, too. I don't think one style is enormously better than the other,
but I do like having the declarations in a predictable location. I
actually find the alternative less readable, but that could just be because
I spend so much time looking at Postgres code.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2024-01-29 15:42:00 | Re: Should we remove -Wdeclaration-after-statement? |
| Previous Message | Andrew Dunstan | 2024-01-29 15:35:51 | Re: [PATCH] Add native windows on arm64 support |