Rename setup_cancel_handler in pg_dump

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Rename setup_cancel_handler in pg_dump
Date: 2024-01-26 00:42:45
Message-ID: 20240126094245.cf6718cc659273765f3ab69a@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Attached is a simple patch to rename setup_cancel_handler()
in pg_dump/parallel.c.

I am proposing it because there is a public function with
the same name in fe_utils/cancel.c. I know pg_dump/parallel.c
does not include fe_utils/cancel.h, so there is no conflict,
but I think it is better to use different names to reduce
possible confusion.

I guess there was no concerns when setup_cancel_handler in
pg_dump/parallel.c was introduced because the same name
function was not in fe_utils that could be used in common
between client tools.. The public setup_cancel_handler in
fe_utils was introduced in a4fd3aa719e, where this function
was moved from psql.

Regards,
Yugo Nagata

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
pg_dump_setup_cancel_handler.patch text/x-diff 1.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-01-26 00:52:17 Re: Use of backup_label not noted in log
Previous Message Yugo NAGATA 2024-01-26 00:42:37 Re: pg_column_toast_chunk_id: a function to get a chunk ID of a TOASTed value