| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove redundant HandleWalWriterInterrupts() |
| Date: | 2024-01-24 19:40:19 |
| Message-ID: | 20240124194019.GB2711912@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 24, 2024 at 07:30:17PM +0530, Bharath Rupireddy wrote:
> On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts()
>> became the same as HandleMainLoopInterrupts(). So I'd like to propose to
>> remove HandleWalWriterInterrupts() and make walwriter use
>> HandleMainLoopInterrupts() instead for improved code simplicity. Thought?
>>
>> Patch attached.
>
> Nice catch. Indeed they both are the same after commit 1bdd54e662. The
> patch LGTM.
LGTM, too.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-01-24 19:44:56 | Re: POC: GROUP BY optimization |
| Previous Message | Nathan Bossart | 2024-01-24 19:39:22 | Re: cleanup patches for incremental backup |