Re: Add \syncpipeline command to pgbench

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add \syncpipeline command to pgbench
Date: 2024-01-22 16:53:13
Message-ID: 202401221653.ekmueaflk3ru@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-Jan-22, Anthonin Bonnefoy wrote:

> 0001 introduces a new error when the end of a pgbench script is
> reached while there's still an ongoing pipeline.

Pushed, backpatched to 14. I reworded the error message to be

client %d aborted: end of script reached with pipeline open

I hope this is OK. I debated a half a dozen alternatives ("with open
pipeline", "without closing pipeline", "with unclosed pipeline" (???),
"leaving pipeline open") and decided this was the least ugly.

Thanks,

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
<inflex> really, I see PHP as like a strange amalgamation of C, Perl, Shell
<crab> inflex: you know that "amalgam" means "mixture with mercury",
more or less, right?
<crab> i.e., "deadly poison"

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-01-22 16:59:34 Re: XLog size reductions: smaller XLRec block header for PG17
Previous Message Tom Lane 2024-01-22 16:35:22 Re: pg_stat_statements and "IN" conditions