Re: Recovering from detoast-related catcache invalidations

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Xiaoran Wang <fanfuxiaoran(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Recovering from detoast-related catcache invalidations
Date: 2024-01-14 20:14:11
Message-ID: 20240114201411.d0@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 12, 2024 at 03:47:13PM -0500, Tom Lane wrote:
> I wrote:
> > This is uncomfortably much in bed with the tuple table slot code,
> > perhaps, but I don't see a way to do it more cleanly unless we want
> > to add some new provisions to that API. Andres, do you have any
> > thoughts about that?
>
> Oh! After nosing around a bit more I remembered systable_recheck_tuple,
> which is meant for exactly this purpose. So v4 attached.

systable_recheck_tuple() is blind to heap_inplace_update(), so it's not a
general proxy for invalidation messages. The commit for $SUBJECT (ad98fb1)
doesn't create any new malfunctions, but I expect the systable_recheck_tuple()
part will change again before the heap_inplace_update() story is over
(https://postgr.es/m/flat/CAMp+ueZQz3yDk7qg42hk6-9gxniYbp-=bG2mgqecErqR5gGGOA(at)mail(dot)gmail(dot)com).

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-01-14 20:34:25 Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)
Previous Message Bharath Rupireddy 2024-01-14 15:02:40 Re: A failure in t/038_save_logical_slots_shutdown.pl