| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | hubert depesz lubaczewski <depesz(at)depesz(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org> |
| Subject: | Re: Wrong datatype in docs for wal_summary_keep_time |
| Date: | 2024-01-09 03:47:22 |
| Message-ID: | 20240109034722.GA3031061@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Jan 08, 2024 at 05:23:11PM -0600, Nathan Bossart wrote:
> On Mon, Jan 08, 2024 at 05:37:14PM +0100, hubert depesz lubaczewski wrote:
>> I was reviewing new changes, and found out that we now have
>> "wal_summary_keep_time" setting, but the docs
>> (https://www.postgresql.org/docs/devel/runtime-config-wal.html#RUNTIME-CONFIG-WAL-SUMMARIZATION)
>> say that it's boolean, while it is integer.
>
> Indeed. I'll try to get this committed tonight unless Robert beats me to
> it.
I noticed that the docs also fail to mention how the value of this
parameter is interpreted when specified without units, so I've put together
a v2 patch that fixes this, too.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-documentation-for-wal_summary_keep_time.patch | text/x-diff | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2024-01-09 04:15:04 | RE: BUG #18267: Logical replication bug: data is not synchronized after Alter Publication. |
| Previous Message | Andrei Lepikhov | 2024-01-09 00:27:45 | Re: BUG #18261: Inconsistent results of SELECT affected by joined subqueries |