Re: about help message for new pg_dump's --filter option

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: about help message for new pg_dump's --filter option
Date: 2023-12-02 16:02:47
Message-ID: 202312021602.wcyxtz5db2oi@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023-Nov-30, Kyotaro Horiguchi wrote:

> Hello.
>
> Recently, a new --filter option was added to pg_dump. I might be
> wrong, but the syntax of the help message for this feels off. Is the
> word 'on' not necessary after 'based'?
>
> > --filter=FILENAME include or exclude objects and data from dump
> > based expressions in FILENAME

Isn't this a bit too long? Maybe we can do something shorter, like

--filter=FILENAME determine objects in dump based on FILENAME

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Those who use electric razors are infidels destined to burn in hell while
we drink from rivers of beer, download free vids and mingle with naked
well shaved babes." (http://slashdot.org/comments.pl?sid=44793&cid=4647152)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shlok Kyal 2023-12-02 16:22:02 Re: undetected deadlock in ALTER SUBSCRIPTION ... REFRESH PUBLICATION
Previous Message Tom Lane 2023-12-02 15:11:20 Re: Emitting JSON to file using COPY TO