From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tristan Partin <tristan(at)neon(dot)tech> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-* |
Date: | 2023-12-01 22:12:55 |
Message-ID: | 20231201221255.d7meekaycfrncorl@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2023-12-01 15:55:29 -0600, Tristan Partin wrote:
> Commits look fine to me, but I hate the new target names...
You shouldn't ever need to use them anywhere - that's what the alias is for...
Happy to go another route if you have a suggestion.
> > + for name, v in targets_info_byname.items():
> > + if len(targets_info_byname[name]) > 1:
>
> My only comment is that you could reverse the logic and save yourself an
> indentation.
>
> - if len(targets_info_byname[name]) > 1:
> + if len(targets_info_byname[name]) <= 1:
> + continue
>
> But whatever you want.
Makes sense.
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2023-12-03 14:41:03 | pgsql: Refactor CreateSharedMemoryAndSemaphores |
Previous Message | Tristan Partin | 2023-12-01 21:55:29 | Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-* |
From | Date | Subject | |
---|---|---|---|
Next Message | Sacha Hottinger | 2023-12-01 23:06:59 | AW: Building PosgresSQL with LLVM fails on Solaris 11.4 |
Previous Message | Tristan Partin | 2023-12-01 22:10:26 | Re: Clean up some signal usage mainly related to Windows |