| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Wrong function name in pgstatfuncs.c |
| Date: | 2023-11-01 08:23:08 |
| Message-ID: | 20231101.172308.1740861597185391383.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Since pgstatfuncs.c was refactored, the comments for synthesized
function names are significant to find the function body.
I happened to find a misspelling among the function name
comments. "pg_stat_get_mods_since_analyze" should be
"pg_stat_get_mod_since_analyze".
Upon checking the file using a rudimentary script, I found no other
similar mistakes in the same file.
(FWIW, I also feel that these macros might be going a bit too far by
synthesizing even the function names.)
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_funcname_in_comment.patch | text/x-patch | 496 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-11-01 08:37:13 | Re: Wrong function name in pgstatfuncs.c |
| Previous Message | Michael Paquier | 2023-11-01 07:24:07 | Re: Is this a problem in GenericXLogFinish()? |