Re: pgsql: Adjust parallel_schedule with event triggers on authenticated lo

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Adjust parallel_schedule with event triggers on authenticated lo
Date: 2023-10-27 10:47:44
Message-ID: 202310271047.mnwkql6nhbwi@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2023-Oct-27, Alexander Korotkov wrote:

> Adjust parallel_schedule with event triggers on authenticated login
>
> Event triggers on authenticated login could catch the connection of the
> concurrent test. In order to prevent this side effect we need to run
> the event_trigger test alone.

Hmm, not a fan, because the original lines of the event_trigger test,
which had no problem running in parallel, no longer do so. Why not
split out only the new part of the test to run in non-parallel mode?
An effortless win of ~50 ms.

After this patch:

ok 211 + stats 644 ms
# parallel group (2 tests): event_trigger oidjoins
ok 212 + oidjoins 103 ms
ok 213 + event_trigger 57 ms
ok 214 - event_trigger_login 16 ms
ok 215 - fast_default 66 ms
ok 216 - tablespace 156 ms
1..216
# All 216 tests passed.

Before:

ok 211 + stats 603 ms
ok 212 - event_trigger 66 ms
ok 213 - oidjoins 113 ms
ok 214 - fast_default 71 ms
ok 215 - tablespace 161 ms
1..215
# All 215 tests passed.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

Attachment Content-Type Size
0001-paralelize-stuff.patch text/x-diff 6.6 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2023-10-27 11:20:58 Re: pgsql: Adjust parallel_schedule with event triggers on authenticated lo
Previous Message Alexander Korotkov 2023-10-27 08:34:49 pgsql: Adjust parallel_schedule with event triggers on authenticated lo