pg_upgrade's object listing

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: pg_upgrade's object listing
Date: 2023-10-27 05:20:55
Message-ID: 20231027.142055.2043576265101382819.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

I found the following message recently introduced in pg_upgrade:

> pg_log(PG_VERBOSE, "slot_name: \"%s\", plugin: \"%s\", two_phase: %s",
> slot_info->slotname,
> slot_info->plugin,
> slot_info->two_phase ? "true" : "false");

If the labels correspond to the struct member names, the first label
ought to be "slotname". If not, all labels of this type, including
those adjucent, should have a more natural spelling.

What do you think about this?

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2023-10-27 05:29:52 Re: A recent message added to pg_upgade
Previous Message Michael Paquier 2023-10-27 05:13:49 Re: [PoC] pg_upgrade: allow to upgrade publisher node