Re: Add trailing commas to enum definitions

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add trailing commas to enum definitions
Date: 2023-10-23 20:34:32
Message-ID: 20231023203432.GA815132@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Oct 23, 2023 at 05:55:32PM +0800, Junwang Zhao wrote:
> On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> Since C99, there can be a trailing comma after the last value in an enum
> C99 allows us to do this doesn't mean we must do this, this is not
> inconsistent IMHO, and this will pollute the git log messages, people
> may *git blame* the file and see the reason for the introduction of the
> line.

I suspect that your concerns about git-blame could be resolved by adding
this commit to .git-blame-ignore-revs. From a long-term perspective, I
think standardizing on the trailing comma style will actually improve
git-blame because patches won't need to add a comma to the previous line
when adding a value.

Nathan Bossart
Amazon Web Services:

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-10-23 20:39:56 Re: Why is hot_standby_feedback off by default?
Previous Message Nathan Bossart 2023-10-23 20:25:42 Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases