| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, jian he <jian(dot)universality(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remaining sql/json patches |
| Date: | 2023-09-28 11:04:54 |
| Message-ID: | 202309281104.kmkr4v34ny2t@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-Sep-27, Amit Langote wrote:
> Maybe the following is better:
>
> + /*
> + * For expression nodes that support soft errors. Should be set to NULL
> + * before calling ExecInitExprRec() if the caller wants errors thrown.
> + */
>
> ...as in the attached.
That's good.
> Alvaro, do you think your concern regarding escontext not being in the
> right spot in the ExprState struct is addressed? It doesn't seem very
> critical to me to place it in the struct's 1st cacheline, because
> escontext is not accessed in performance critical paths such as during
> expression evaluation, especially with the latest version. (It would
> get accessed during evaluation with previous versions.)
>
> If so, I'd like to move ahead with committing it.
Yeah, looks OK to me in v21.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrice Chapuis | 2023-09-28 11:11:41 | wal recycling problem |
| Previous Message | Jakub Wartak | 2023-09-28 10:22:07 | Re: trying again to get incremental backup |