Re: [PGdocs] fix description for handling pf non-ASCII characters

From: "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PGdocs] fix description for handling pf non-ASCII characters
Date: 2023-09-28 05:58:28
Message-ID: 20230928005828.549a23a1@slate.karlpinc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 28 Sep 2023 12:54:33 +0900
Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> I was looking at this thread overall, the three v3 flavors of the doc
> changes and v4.
>
> - <varname>application_name</varname> value. Other characters
> will be
> - replaced with question marks (<literal>?</literal>).
> + <varname>application_name</varname> value.
> + Other characters are replaced with <link
> + linkend="sql-syntax-strings-escape">C-style hexadecimal
> escapes</link>.
>
> The simplicity of the change in v4 seems like the best approach to me,
> so +1 for that (including the mention to "C-style").

I agree with Tom that it's not worth spending anyone's attention
on bytes v.s. characters.

So I'm marking the patch ready for committer.
(I have not tried the version that patches against PGv16.)

Thank you everyone, especially Hayato, for spending time
and making this better.

Regards,

Karl <kop(at)karlpinc(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Pyhalov 2023-09-28 06:15:43 Re: Partial aggregates pushdown
Previous Message Bharath Rupireddy 2023-09-28 05:14:06 Re: [PoC] pg_upgrade: allow to upgrade publisher node