Re: psql help message contains excessive indentations

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: psql help message contains excessive indentations
Date: 2023-09-07 07:08:10
Message-ID: 20230907160810.1a4171e3cd1b648f5eb55ed0@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 07 Sep 2023 15:36:10 +0900 (JST)
Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:

> At Thu, 7 Sep 2023 15:02:49 +0900, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote in
> > On Thu, 07 Sep 2023 14:29:56 +0900 (JST)
> > Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > > > \q quit psql
> > > > \watch [[i=]SEC] [c=N] [m=MIN]
> > > !> execute query every SEC seconds, up to N times
> > > !> stop if less than MIN rows are returned
> > >
> > > The last two lines definitely have some extra indentation.
> >
> > Agreed.
> >
> > > I've attached a patch that fixes this.
> >
> > I wonder this better to fix this in similar way to other places where the
> > description has multiple lines., like "\g [(OPTIONS)] [FILE]".
>
> It looks correct to me:

Yes. So, I mean how about fixing \watch description as the attached patch.

>
> > \errverbose show most recent error message at maximum verbosity
> > \g [(OPTIONS)] [FILE] execute query (and send result to file or |pipe);
> > \g with no arguments is equivalent to a semicolon
> > \gdesc describe result of query, without executing it
>
> regards.
>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
v2_psql_help_remove_extra_indentation.patch text/x-diff 873 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-09-07 07:25:27 Re: Impact of checkpointer during pg_upgrade
Previous Message Hayato Kuroda (Fujitsu) 2023-09-07 07:07:36 pg_ctl start may return 0 even if the postmaster has been already started on Windows