Re: cataloguing NOT NULL constraints

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: cataloguing NOT NULL constraints
Date: 2023-08-23 17:08:18
Message-ID: 20230823170818.v22xaa432h6ttwjf@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I went over the whole patch and made a very large number of additional
cleanups[1], to the point where I think this is truly ready for commit now.
There are some relatively minor things that could still be subject of
debate, such as what to name constraints that derive from PKs or from
multiple inheritance parents. I have one commented out Assert() because
of that. But other than those and a couple of not-terribly-important
XXX comments, this is as ready as it'll ever be.

I'll put it through CI soon. It's been a while since I tested using
pg_upgrade from older versions, so I'll do that too. If no problems
emerge, I intend to get this committed soon.


Álvaro Herrera PostgreSQL Developer —
"If you want to have good ideas, you must have many ideas. Most of them
will be wrong, and what you have to learn is which ones to throw away."
(Linus Pauling)

Attachment Content-Type Size
v19-0001-Catalog-NOT-NULL-constraints.patch text/x-diff 289.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-08-23 17:44:11 Re: Oversight in reparameterize_path_by_child leading to executor crash
Previous Message Tom Lane 2023-08-23 17:04:26 Re: using SysCacheGetAttrNotNull in place of heap_getattr