| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Brown <michael(dot)brown(at)discourse(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: should frontend tools use syncfs() ? |
| Date: | 2023-08-22 02:06:32 |
| Message-ID: | 20230822020632.GA565843@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 22, 2023 at 10:50:01AM +0900, Michael Paquier wrote:
> On Mon, Aug 21, 2023 at 06:44:07PM -0700, Nathan Bossart wrote:
>> I'm hoping there's a simpler path forward here. pg_rewind only needs the
>> following lines from fd.h:
>>
>> /* Filename components */
>> #define PG_TEMP_FILES_DIR "pgsql_tmp"
>> #define PG_TEMP_FILE_PREFIX "pgsql_tmp"
>>
>> Maybe we could move these to file_utils.h instead. WDYT?
>
> I guess so.. At the same time, something can be said about
> pg_checksums that redeclares PG_TEMP_FILE_PREFIX and PG_TEMP_FILES_DIR
> because it does not want to include fd.h and its sync routines.
This would look something like the attached patch. I think this is nicer.
With this patch, we don't have to choose between including fd.h or
redefining the macros in the frontend code.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-move-PG_TEMP_FILE-macros-to-file_utils.h.patch | text/x-diff | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jian Guo | 2023-08-22 02:35:30 | Re: Wrong rows estimations with joins of CTEs slows queries by more than factor 500 |
| Previous Message | Michael Paquier | 2023-08-22 01:50:01 | Re: should frontend tools use syncfs() ? |