Re: run pgindent on a regular basis / scripted manner

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Jelte Fennema <postgres(at)jeltef(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: 2023-08-17 14:40:41
Message-ID: 20230817144041.GA3099457@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Aug 16, 2023 at 01:15:55PM -0700, Peter Geoghegan wrote:
> On Tue, Aug 15, 2023 at 1:31 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> Should we add those? Patch attached.
> I think that that makes sense.


> I just don't want to normalize updating
> .git-blame-ignore-revs very frequently. (Actually, it's more like I
> don't want to normalize any scheme that makes updating the ignore list
> very frequently start to seem reasonable.)

Agreed. I've found myself habitually running pgindent since becoming a
committer, but I'm sure I'll forget it one of these days. From a quick
skim of this thread, it sounds like a pre-commit hook [0] might be the best
option at the moment.


Nathan Bossart
Amazon Web Services:

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2023-08-17 14:59:10 Re: PG 16 draft release notes ready
Previous Message PG Bug reporting form 2023-08-17 14:35:23 BUG #18059: Unexpected error 25001 in stored procedure