| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: add timing information to pg_upgrade |
| Date: | 2023-08-01 15:45:54 |
| Message-ID: | 20230801154554.GA723589@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 01, 2023 at 09:46:02AM +0200, Peter Eisentraut wrote:
> On 31.07.23 20:37, Nathan Bossart wrote:
>> - prep_status("Checking for incompatible \"aclitem\" data type in user tables");
>> + prep_status("Checking for \"aclitem\" data type in user tables");
>
> Why these changes? I think this is losing precision about what it's doing.
The message is too long, so there's no space between it and the "ok"
message:
Checking for incompatible "aclitem" data type in user tablesok
Instead of altering the messages, we could bump MESSAGE_WIDTH from 60 to
62 or 64. Do you prefer that approach? (BTW this probably needs to be
back-patched to v16.)
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Malakhov | 2023-08-01 15:47:28 | Re: POC: Extension for adding distributed tracing - pg_tracing |
| Previous Message | Ahmed Ibrahim | 2023-08-01 15:19:15 | Re: There should be a way to use the force flag when restoring databases |