Re: Simplify some logical replication worker type checking

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Simplify some logical replication worker type checking
Date: 2023-08-01 06:40:46
Message-ID: 20230801064046.3jpxf5vivmwry4um@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023-Aug-01, Peter Smith wrote:

> PSA a small patch making those above-suggested changes. The 'make
> check' and TAP subscription tests are all passing OK.

I think the code ends up more readable with this style of changes, so
+1. I do wonder if these calls should appear in a proc_exit callback or
some such instead, though.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"No tengo por qué estar de acuerdo con lo que pienso"
(Carlos Caszeli)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2023-08-01 06:46:55 Re: Fix compilation warnings when CFLAGS -Og is specified
Previous Message vignesh C 2023-08-01 06:32:29 Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication