Re: Ignore 2PC transaction GIDs in query jumbling

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Ignore 2PC transaction GIDs in query jumbling
Date: 2023-08-01 02:22:09
Message-ID: 20230801022209.4ac2c4shvmu2fnnq@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Aug 01, 2023 at 11:00:32AM +0900, Michael Paquier wrote:
> On Tue, Aug 01, 2023 at 09:28:08AM +0800, Julien Rouhaud wrote:
> > FTR we had to entirely ignore all those statements in powa years ago to try to
> > make the tool usable in such case for some users who where using 2pc, it would
> > be nice to be able to track them back for pg16+.
> That would be nice for your users.

Indeed, although I will need to make that part a runtime variable based on the
server version rather than a hardcoded string since the extension framework
doesn't provide a way to do that cleanly across major pg versions.

> Are there more query patterns you'd
> be interested in grouping in the backend? I had a few folks aiming
> for CallStmt and SetStmt, but both a a bit tricky without a custom
> routine.

Looking at the rest of the ignored patterns, the only remaining one would be
DEALLOCATE, which AFAICS doesn't have a query_jumble_ignore tag for now.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-08-01 02:33:36 Re: Inaccurate comments in ReorderBufferCheckMemoryLimit()
Previous Message Laurenz Albe 2023-08-01 02:07:24 Re: [PATCH] Add support function for containment operators